Skip to content

Enforced import ordering in eslint#2045

Merged
smartcontracts merged 1 commit intoethereum-optimism:developfrom
indeavr:develop
Jan 24, 2022
Merged

Enforced import ordering in eslint#2045
smartcontracts merged 1 commit intoethereum-optimism:developfrom
indeavr:develop

Conversation

@indeavr
Copy link
Contributor

@indeavr indeavr commented Jan 21, 2022 •
edited
Loading

Description
The order of imports in TS files is now standardized by eslint.

  1. external builtin
  2. builtin external
  3. internal
  4. sibling
  5. parent
  6. index
  • New Line is separating each group.

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: a7239b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-op-batcher Area: op-batcher A-pkg-core-utils Area: packages/core-utils A-integration Area: integration tests labels Jan 21, 2022
@smartcontracts
Copy link
Contributor

smartcontracts commented Jan 21, 2022

Whew, thanks for doing this! I think builtin should go before external, and is it possible to just do internal instead of separating sibling/parent/index?

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022 •
edited
Loading

Codecov Report

Merging #2045 (e2aa772) into develop (e8ea965) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e2aa772 differs from pull request most recent head 41d6dc1. Consider uploading reports for the commit 41d6dc1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2045   +/-   ##
========================================
  Coverage    74.58%   74.58%           
========================================
  Files           79       79           
  Lines         2554     2554           
  Branches       401      401           
========================================
  Hits          1905     1905           
  Misses         649      649
Flag Coverage Δ
batch-submitter 62.50% <100.00%> (ø)
contracts 90.48% <ø> (ø)
core-utils 57.50% <100.00%> (ø)
data-transport-layer 38.64% <100.00%> (ø)
message-relayer 70.86% <ø> (ø)
sdk 88.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...h-submitter/src/batch-submitter/batch-submitter.ts 83.15% <ø> (ø)
packages/core-utils/src/alias.ts 81.81% <ø> (ø)
packages/core-utils/src/bn.ts 100.00% <ø> (ø)
packages/core-utils/src/common/test-utils.ts 95.55% <ø> (ø)
packages/core-utils/src/fees.ts 52.94% <ø> (ø)
...ices/l1-ingestion/handlers/transaction-enqueued.ts 53.84% <ø> (ø)
packages/sdk/src/cross-chain-provider.ts 82.67% <ø> (ø)
packages/sdk/src/utils/coercion.ts 88.46% <ø> (ø)
packages/sdk/src/utils/message-encoding.ts 100.00% <ø> (ø)
...itter/src/batch-submitter/state-batch-submitter.ts 75.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ea965...41d6dc1. Read the comment docs.

@github-actions github-actions bot added the A-cannon Area: cannon label Jan 24, 2022
@github-actions github-actions bot removed the A-cannon Area: cannon label Jan 24, 2022
@indeavr indeavr force-pushed the develop branch 2 times, most recently from f609013 to e050ed5 Compare January 24, 2022 07:06
@github-actions github-actions bot added the A-cannon Area: cannon label Jan 24, 2022
@indeavr indeavr force-pushed the develop branch 2 times, most recently from 41d6dc1 to eb8017f Compare January 24, 2022 07:13
@github-actions github-actions bot removed the A-cannon Area: cannon label Jan 24, 2022
smartcontracts
smartcontracts approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work here, thank you!

@tynes
Copy link
Contributor

tynes commented Jan 24, 2022

Looks good to me, double checked the diff. Can you add patch changesets for each package with a diff? Then will be good to merge

@smartcontracts
Copy link
Contributor

smartcontracts commented Jan 24, 2022

Looks good to me, double checked the diff. Can you add patch changesets for each package with a diff? Then will be good to merge

FWIW I don't think it really needs a changeset since no functionality is changing

@smartcontracts
Copy link
Contributor

smartcontracts commented Jan 24, 2022

Gonna merge this, I don't think it needs a changeset since no functionality is changing.

@smartcontracts smartcontracts merged commit 4d7c545 into ethereum-optimism:develop Jan 24, 2022
@smartcontracts
Copy link
Contributor

smartcontracts commented Jan 24, 2022

Great work @indeavr, thank you!

theochap pushed a commit that referenced this pull request Dec 10, 2025
@PoulavBhowmick03
feat(node/service): removed unbounded channels in kona-service actors…
936845b 
… and replaced with bounded ones (#2045)

Fixes #1993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

A-integration Area: integration tests A-op-batcher Area: op-batcher A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@indeavr @smartcontracts @codecov-commenter @tynes